ENH Rebuild client/dist on merge-up #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/1.0/js
branch
from
ecef677 to
25726e4
Compare
emteknetnz
commented
Aug 1, 2023
7 tasks
GuySartorelli
requested changes
Aug 2, 2023
emteknetnz
force-pushed
the
pulls/1.0/js
branch
from
25726e4 to
a518b22
Compare
|
@GuySartorelli Have made updated and triggered a new run with updated code https://github.com/emteknetnz/silverstripe-asset-admin/actions/runs/5744754116/job/15571608089 |
GuySartorelli
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3
Example action run - https://github.com/emteknetnz/silverstripe-asset-admin/actions/runs/5744754116/job/15571608089
Example commits - https://github.com/emteknetnz/silverstripe-asset-admin/commits/2
Re the AC
The build fails if there is any issue with yarn build-yarn buildwill omit an non-zero exit code on failure, which will immediately cause the github workflow to immediately stop